-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Support min fees in a localnet and fix gaiad config #3172
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3172 +/- ##
===========================================
- Coverage 54.88% 54.86% -0.02%
===========================================
Files 132 132
Lines 9446 9452 +6
===========================================
+ Hits 5184 5186 +2
- Misses 3943 3947 +4
Partials 319 319 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Tested locally too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Just a little remark: this should be listed as breaking change due to a exported function in baseapp (SetMinimumFees
) being unexported.
1stake
)Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: