-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Refactor Gas/Fee Model #3258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
wip
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
labels
Jan 8, 2019
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
January 8, 2019 20:30
alexanderbez
force-pushed
the
bez/3248-fee-model-refactor-i
branch
from
January 8, 2019 20:34
ac4b6a0
to
57e6d29
Compare
alexanderbez
requested review from
jackzampolin and
gamarin2
and removed request for
ebuchman
January 9, 2019 19:30
Now that we're using gasPrice as metric we could open a follow-up issue with optional mempool sorting by fee. |
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
…mos-sdk into bez/3248-fee-model-refactor-i
jackzampolin
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those comments quickly @alexanderbez. I reviewed with a focus on docs and tests, and this PR is looking ready to merge!
fedekunze
reviewed
Jan 18, 2019
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
This was referenced Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum-fees
in favor ofminimum-gas-prices
gasPrices >= minGasPrices
gasPrices
are of typeDecCoins
, I had to add a fair amount of functionality toDec
andDecCoin/s
.Note: I'll be happy to move all the decimal related changes to a separate PR if that will help ease review.
closes: #3248
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: