Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Refactor Gas/Fee Model #3258

Merged
merged 58 commits into from
Jan 18, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 8, 2019

  • Remove minimum-fees in favor of minimum-gas-prices
  • Update ante handler to check gasPrices >= minGasPrices
  • Since gasPrices are of type DecCoins, I had to add a fair amount of functionality to Dec and DecCoin/s.
  • Remove OR semantics when determining if min fees are provided in a tx. Instead, we revert back to AND semantics (per convo w/ @jaekwon and @zmanian).

Note: I'll be happy to move all the decimal related changes to a separate PR if that will help ease review.

closes: #3248


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added wip T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jan 8, 2019
@gamarin2 gamarin2 mentioned this pull request Jan 8, 2019
@alexanderbez alexanderbez requested review from jackzampolin and gamarin2 and removed request for ebuchman January 9, 2019 19:30
@hendrikhofstadt
Copy link
Contributor

Now that we're using gasPrice as metric we could open a follow-up issue with optional mempool sorting by fee.

docs/gaia/gaiacli.md Outdated Show resolved Hide resolved
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
@alexanderbez
Copy link
Contributor Author

@cwgoes @jaekwon this should be r4r again.

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those comments quickly @alexanderbez. I reviewed with a focus on docs and tests, and this PR is looking ready to merge!

baseapp/options.go Outdated Show resolved Hide resolved
client/utils/rest.go Show resolved Hide resolved
client/utils/rest.go Outdated Show resolved Hide resolved
fedekunze and others added 2 commits January 18, 2019 10:40
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
Co-Authored-By: alexanderbez <alexanderbez@users.noreply.github.com>
@jackzampolin jackzampolin merged commit 36d1736 into develop Jan 18, 2019
@jackzampolin jackzampolin deleted the bez/3248-fee-model-refactor-i branch January 18, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fee Model Revision
6 participants