R4R: Add length caps for governance proposal titles and descriptions #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
sunnya97
changed the title
sunnya97
added
C:x/gov
T: API Breaking
jackzampolin
requested changes
Jan 29, 2019
fedekunze
reviewed
Jan 29, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3434 +/- ##
===========================================
- Coverage 59.36% 59.28% -0.08%
===========================================
Files 134 134
Lines 9972 9953 -19
===========================================
- Hits 5920 5901 -19
Misses 3679 3679
Partials 373 373 |
cwgoes
approved these changes
Jan 29, 2019
jackzampolin
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3420
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: