Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add --jail-whitelist to gaiad export #3454

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Conversation

jackzampolin
Copy link
Member

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #3454 into develop will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop    #3454     +/-   ##
==========================================
- Coverage    59.44%   59.34%   -0.1%     
==========================================
  Files          130      130             
  Lines         9804     9817     +13     
==========================================
- Hits          5828     5826      -2     
- Misses        3606     3621     +15     
  Partials       370      370

@jackzampolin jackzampolin merged commit c766993 into develop Feb 4, 2019
@jackzampolin jackzampolin deleted the jack/jail-on-export branch February 4, 2019 16:42
@njmurarka
Copy link
Contributor

njmurarka commented Oct 24, 2020

I am not sure this is working, or do not know how it works.

I did the following:

blzd export --for-zero-height --jail-whitelist bluzellevaloper10ymgqrvrxq2ux5hs22v09ucut8yet05n62unyj,bluzellevaloper1p6duj9wkhtm42xx0esdq9xg7852p6tfm0rlu64

I also did the following:

blzd export --for-zero-height

The output (other than the first line, which is the date and timestamp of when the export was done) are identical.

I will file a bug. I do think this feature needs more verbosity in terms of how to use it. It is much more important than some of us realize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants