Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Fix for make test_unit #3582

Merged
merged 2 commits into from
Feb 11, 2019
Merged

R4R: Fix for make test_unit #3582

merged 2 commits into from
Feb 11, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented Feb 10, 2019 •
edited
Loading

Running make test_unit was failing because a tag was missing.
I think that this tiny fix does not require an entry in pending.md but I am happy to do it if required.

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni requested a review from alessio February 10, 2019 10:13
@alessio alessio changed the title Fix for make test_unit R4R: Fix for make test_unit Feb 10, 2019
alessio
alessio approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works for me. ACK'd.

@cwgoes cwgoes merged commit 4282c6a into cosmos:develop Feb 11, 2019
@jleni jleni deleted the fix/unit_tests branch February 11, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleni @alessio @alexanderbez @cwgoes