Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Message & Codec Registration Consistency #3673

Merged
merged 12 commits into from
Feb 25, 2019
Merged

R4R: Message & Codec Registration Consistency #3673

merged 12 commits into from
Feb 25, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 18, 2019 •
edited
Loading

closes: #3669

/cc @kwunyeung (please let me know if I missed anything)

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 18, 2019
@alexanderbez alexanderbez changed the title WIP: Message & Codec Registration Consistency R4R: Message & Codec Registration Consistency Feb 18, 2019
jackzampolin
jackzampolin reviewed Feb 18, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes. This PR is, however, breaking. We just need to think about which release to land this in.

@codecov
Copy link

codecov bot commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #3673 into develop will increase coverage by 0.02%.
The diff coverage is 84.8%.

@@             Coverage Diff             @@
##           develop    #3673      +/-   ##
===========================================
+ Coverage    61.15%   61.18%   +0.02%     
===========================================
  Files          190      190              
  Lines        14008    14008              
===========================================
+ Hits          8567     8571       +4     
+ Misses        4905     4901       -4     
  Partials       536      536

@alexanderbez
Copy link
Contributor Author

@jackzampolin indeed we do. I suppose for 0.33?

@alexanderbez alexanderbez removed this from the v0.33.0 (Enable Transfers) milestone Feb 18, 2019
@alexanderbez alexanderbez added T: State Machine Breaking State machine breaking changes (impacts consensus). and removed T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Feb 18, 2019
cwgoes
cwgoes suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing changes look good, but:

  • ag validator_src_addr pulls up a few more instances in REST bech-JSON structs
  • I think we should use _ in tags to be consistent with JSON (cc @rigelrozanski though who might disagree)

@alexanderbez
Copy link
Contributor Author

@cwgoes thanks for the catch!

@jackzampolin
Copy link
Member

Also maybe this PR should include a style guide so we have this convention written down somewhere.

rigelrozanski
rigelrozanski reviewed Feb 19, 2019
View reviewed changes
x/staking/types/msg.go Outdated Show resolved Hide resolved
x/staking/types/msg.go Outdated Show resolved Hide resolved
x/staking/types/msg.go Outdated Show resolved Hide resolved
@jackzampolin
Copy link
Member

This is now failing tests and has merge conflicts :(

@alexanderbez
Copy link
Contributor Author

@jackzampolin @rigelrozanski @alessio @cwgoes updated

@cwgoes
Copy link
Contributor

cwgoes commented Feb 22, 2019

Needs a rebase, unfortunately.

@cwgoes
Copy link
Contributor

cwgoes commented Feb 22, 2019

ACK pending rebase.

@alexanderbez
Copy link
Contributor Author

Updated @cwgoes

@cwgoes cwgoes merged commit b9be116 into develop Feb 25, 2019
@cwgoes cwgoes deleted the bez/3669-msg-inconsistency branch February 25, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin left review comments

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes cwgoes approved these changes

@alessio alessio Awaiting requested review from alessio

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
T: State Machine Breaking State machine breaking changes (impacts consensus). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency of message types and json keys in modules
5 participants
@alexanderbez @jackzampolin @cwgoes @alessio @rigelrozanski