Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R CCI: Add tags for every version in docker repo #3684

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Feb 19, 2019

  • Every version change will have its own docker image, ready to be pulled by clients

  • CircleCi configuration push those tags, or override them if already present

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests n/a

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue # n/a

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #3684 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3684      +/-   ##
===========================================
- Coverage     60.6%   60.59%   -0.02%     
===========================================
  Files          189      189              
  Lines        14236    14236              
===========================================
- Hits          8628     8626       -2     
- Misses        5063     5065       +2     
  Partials       545      545

@sabau sabau changed the title CCI: Add tags for every version in docker repo R4R CCI: Add tags for every version in docker repo Feb 19, 2019
@jackzampolin jackzampolin merged commit 95710f1 into develop Feb 19, 2019
@jackzampolin jackzampolin deleted the sabau/docker-image-tags branch February 19, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants