Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Tendermint Version to 0.30.1 #3699

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Bump Tendermint Version to 0.30.1 #3699

merged 3 commits into from
Feb 25, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 20, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Contributor

I think this needs to go into the 0.32.1 release branch as well.

@codecov
Copy link

codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@cc938b8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #3699   +/-   ##
==========================================
  Coverage           ?   61.18%           
==========================================
  Files              ?      190           
  Lines              ?    14042           
  Branches           ?        0           
==========================================
  Hits               ?     8591           
  Misses             ?     4913           
  Partials           ?      538

@alexanderbez alexanderbez changed the title Bump tendermint version up Bump Tendermint Version to 0.30.1 Feb 21, 2019
cwgoes
cwgoes suggested changes Feb 25, 2019
View reviewed changes
Gopkg.toml
@@ -36,11 +36,11 @@

[[override]]
name = "github.com/tendermint/iavl"
version = "v0.12.0"
version = "~v0.12.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change instead of an exact version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(resolved per discussion)

PENDING.md
@@ -49,6 +49,8 @@

### Tendermint

* [\#3699] Upgrade to Tendermint 0.30.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and IAVL v???

@cwgoes cwgoes merged commit 6d2da06 into develop Feb 25, 2019
@cwgoes cwgoes deleted the tendermint-0.30.1 branch February 25, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @jackzampolin @cwgoes