Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap Undelegation for Vesting Accounts #3718

Closed
wants to merge 10 commits into from

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 22, 2019

Proposal to limit the deduction from DelegatedVesting by at most DelegatedVesting during undelegation, due to the fact that an undelegation amount may exceed the original (vesting) delegation amount.

/cc @cwgoes @jaekwon @rigelrozanski @zmanian


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Feb 22, 2019

Multi-seed sim failing w/ weird faults:

seed 123, 582 (probably the rest):

 Validator consensus-address D32D82B20BA034E82966BDCC214A12627D188562 not found

This comes from handleDoubleSign. Thoughts @cwgoes or @rigelrozanski?

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #3718 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3718      +/-   ##
===========================================
+ Coverage    61.15%   61.16%   +<.01%     
===========================================
  Files          190      190              
  Lines        14008    14009       +1     
===========================================
+ Hits          8567     8568       +1     
  Misses        4905     4905              
  Partials       536      536

@alexanderbez alexanderbez marked this pull request as ready for review February 25, 2019 00:26
@alexanderbez alexanderbez changed the base branch from cwgoes/debug-vesting-finding to develop February 25, 2019 00:27
@cwgoes
Copy link
Contributor

cwgoes commented Feb 25, 2019

This seems to be superseded by #3717.

@alexanderbez
Copy link
Contributor Author

Yeah I guess we can close it ☹️

@alexanderbez alexanderbez deleted the bez/vesting-undelegation-cap-fix branch February 25, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants