Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: launch rc jae #3736

Closed
wants to merge 14 commits into from
Closed

DNM: launch rc jae #3736

wants to merge 14 commits into from

Conversation

rigelrozanski
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Feb 25, 2019 •
edited
Loading

Does this supplant #3717? #3726 too? I'm a bit confused.

If possible I'd prefer we review fixes in separate PRs.

@jackzampolin
Copy link
Member

Agree with @cwgoes here too.

@rigelrozanski
Copy link
Contributor Author

lol you guys are jumpin' the gun this is a DNM PR aka DO NOT MERGE aka DO NOT WORRY - I'm using this for debugging

@cwgoes cwgoes deleted the jae/launch-rc-jae branch February 28, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rigelrozanski @cwgoes @jackzampolin @jaekwon