Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Support query txs' TotalCount in GET /txs #3942 #3995

Closed
wants to merge 4 commits into from
Closed

R4R: Support query txs' TotalCount in GET /txs #3942 #3995

wants to merge 4 commits into from

Conversation

yangyanqing
Copy link
Contributor

close: #3942

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #3995 into develop will decrease coverage by 0.04%.
The diff coverage is 38.46%.

@@             Coverage Diff             @@
##           develop    #3995      +/-   ##
===========================================
- Coverage    60.19%   60.15%   -0.05%     
===========================================
  Files          212      212              
  Lines        15157    15166       +9     
===========================================
- Hits          9124     9123       -1     
- Misses        5409     5419      +10     
  Partials       624      624

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yangyanqing! Left some feedback, but overall looks solid.

client/tx/search.go Outdated Show resolved Hide resolved
client/tx/search.go Outdated Show resolved Hide resolved
client/lcd/test_helpers.go Show resolved Hide resolved
client/tx/search.go Outdated Show resolved Hide resolved
types/result.go Outdated Show resolved Hide resolved
@yangyanqing yangyanqing changed the title Support query txs' TotalCount in GET /txs #3942 R4R: Support query txs' TotalCount in GET /txs #3942 Apr 1, 2019
@ebuchman ebuchman closed this Apr 26, 2019
@yangyanqing yangyanqing deleted the frank/3942-support-TotalCount-in-GET-txs branch April 27, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants