Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Sample Implementation #4118

Closed
wants to merge 8 commits into from
Closed

NFT Sample Implementation #4118

wants to merge 8 commits into from

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Apr 15, 2019

Work by @fedekunze and @okwme on a NFT module!

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/nfts/handler.go Outdated Show resolved Hide resolved
x/nfts/handler.go Outdated Show resolved Hide resolved
x/nfts/errors.go Outdated Show resolved Hide resolved
x/nfts/errors.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #4118 into develop will decrease coverage by 1.74%.
The diff coverage is 7.57%.

@@             Coverage Diff             @@
##           develop    #4118      +/-   ##
===========================================
- Coverage    59.98%   58.23%   -1.75%     
===========================================
  Files          211      221      +10     
  Lines        15131    15626     +495     
===========================================
+ Hits          9076     9100      +24     
- Misses        5433     5901     +468     
- Partials       622      625       +3

@jackzampolin jackzampolin changed the title Billy-Fede/nft NFT Sample Implementation Apr 23, 2019
@ebuchman ebuchman closed this Apr 26, 2019
@rigelrozanski
Copy link
Contributor

This PR needs to be reopened to Master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants