Discard error returned by os.RemoveAll() when pruning test dirs #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #4264 +/- ##
=========================================
Coverage ? 59.12%
=========================================
Files ? 217
Lines ? 14587
Branches ? 0
=========================================
Hits ? 8625
Misses ? 5324
Partials ? 638 |
alessio
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
reviewed
May 3, 2019
| @@ -353,7 +353,7 @@ func InitializeTestLCD(t *testing.T, nValidators int, initAddrs []sdk.AccAddress | |||
| node.Stop() //nolint:errcheck | |||
| node.Wait() | |||
| lcd.Close() | |||
| require.NoError(t, os.RemoveAll(config.RootDir)) | |||
| os.RemoveAll(config.RootDir) | |||
There was a problem hiding this comment.
Do we expect the error here to be non-deterministic? Why remove?
There was a problem hiding this comment.
Yes, that's correct. Some directories may not be removed because there are processes that are still writing files into them at the time of the removal. We shall replace the lcd tests in the near future, I wouldn't spend too much time into investigating this small thing.
alexanderbez
approved these changes
May 3, 2019
|
Merging as this is blocking other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: