Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TxSigLimit instead of default constant value #4396

Merged
merged 3 commits into from
May 23, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented May 22, 2019

closes: #4394


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #4396 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4396      +/-   ##
==========================================
+ Coverage   57.21%   57.24%   +0.02%     
==========================================
  Files         241      241              
  Lines       15126    15131       +5     
==========================================
+ Hits         8654     8661       +7     
+ Misses       5842     5840       -2     
  Partials      630      630

Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this makes sense - so we've moved the sig check logic from ValidateBasic (on stdTx) to a new check directly above this within NewAnteHandler. Got it looks, good.

@alexanderbez alexanderbez merged commit 4f197ff into master May 23, 2019
@alexanderbez alexanderbez deleted the bez/4394-fix-sig-limit-check branch May 23, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TxSigLimit checking logic bug
2 participants