Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LCD submit delegation doc to match v0.34 #4445

Merged
merged 2 commits into from
May 30, 2019

Conversation

kwunyeung
Copy link
Contributor

fix #4406

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez
Copy link
Contributor

@kwunyeung can you please run make update-swagger-docs to update the built swagger file please?

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #4445 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   54.58%   54.58%           
=======================================
  Files         248      248           
  Lines       15967    15967           
=======================================
  Hits         8716     8716           
  Misses       6617     6617           
  Partials      634      634

1 similar comment
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #4445 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   54.58%   54.58%           
=======================================
  Files         248      248           
  Lines       15967    15967           
=======================================
  Hits         8716     8716           
  Misses       6617     6617           
  Partials      634      634

@alexanderbez alexanderbez merged commit b44392b into cosmos:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger still showing "delegation" instead of "amount" for LCD
3 participants