Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG from v0.34.6 Release #4452

Merged
merged 1 commit into from
May 30, 2019

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added the T:Docs Changes and features related to documentation. label May 30, 2019
@alexanderbez alexanderbez requested review from fedekunze and sabau May 30, 2019 19:24
@alexanderbez alexanderbez merged commit 9969ef9 into master May 30, 2019
@alexanderbez alexanderbez deleted the bez/changelog-v0.34.6-update branch May 30, 2019 19:26
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #4452 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4452   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         250      250           
  Lines       16061    16061           
=======================================
  Hits         8777     8777           
  Misses       6639     6639           
  Partials      645      645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants