Improve Import/Export Simulation Errors #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4607 +/- ##
=========================================
+ Coverage 54.11% 54.6% +0.48%
=========================================
Files 260 260
Lines 16371 16530 +159
=========================================
+ Hits 8859 9026 +167
+ Misses 6866 6858 -8
Partials 646 646 |
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
changed the title
fedekunze
changed the title
alexanderbez
suggested changes
Jun 27, 2019
…/cosmos-sdk into fedekunze/4535-simulation
fedekunze
commented
Jun 28, 2019
| var ( | ||
| ValidatorSigningInfoKey = []byte{0x01} // Prefix for signing info | ||
| ValidatorMissedBlockBitArrayKey = []byte{0x02} // Prefix for missed block bit array | ||
| ValidatorSlashingPeriodKey = []byte{0x03} // Prefix for slashing period |
There was a problem hiding this comment.
this key was not being used
fedekunze
changed the title
…dekunze/4535-simulation
4 tasks
alexanderbez
approved these changes
Jun 28, 2019
alessio
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4535
cc: @npinto
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: