Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty/Flatten Events by Type when Stringified #4648

Merged
merged 1 commit into from
Jun 30, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 30, 2019

When events are stringified, they'll be easier to read if they're grouped by unique type.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 30, 2019

Codecov Report

Merging #4648 into master will increase coverage by 0.14%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #4648      +/-   ##
==========================================
+ Coverage   54.83%   54.97%   +0.14%     
==========================================
  Files         272      272              
  Lines       17020    17027       +7     
==========================================
+ Hits         9333     9361      +28     
+ Misses       7001     6980      -21     
  Partials      686      686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants