Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup node_info Endpoint #4837

Merged
merged 12 commits into from
Aug 2, 2019
Merged

Cleanup node_info Endpoint #4837

merged 12 commits into from
Aug 2, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 2, 2019

  • Remove some redundant code and endpoints
  • Update node_info endpoint to also include application version info

new output:

{
    "application_version": {
        "build_tags": "netgo,ledger",
        "client_name": "gaiacli",
        "commit": "c1ae72295c72ce548f271c8c337aeb662a48b5a2",
        "go": "go version go1.12.5 darwin/amd64",
        "name": "gaia",
        "server_name": "gaiad",
        "version": "0.0.0-43-gc1ae722"
    },
    "node_info": {
        "channels": "4020212223303800",
        "id": "55b46a2f3f5cb1d9e8d092c5c4cdb21d158553c9",
        "listen_addr": "tcp://0.0.0.0:26656",
        "moniker": "node0",
        "network": "chain-16yZ57",
        "other": {
            "rpc_address": "tcp://0.0.0.0:26657",
            "tx_index": "on"
        },
        "protocol_version": {
            "app": "0",
            "block": "10",
            "p2p": "7"
        },
        "version": "0.32.1"
    }
}

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #4837 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4837      +/-   ##
==========================================
- Coverage   54.18%   54.14%   -0.05%     
==========================================
  Files         269      269              
  Lines       17191    17209      +18     
==========================================
+ Hits         9315     9317       +2     
- Misses       7186     7202      +16     
  Partials      690      690

@alexanderbez alexanderbez added R4R and removed WIP labels Aug 2, 2019
@alexanderbez alexanderbez marked this pull request as ready for review August 2, 2019 14:21
.pending/breaking/rest/_Remove-version-and- Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
version/command.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
alexanderbez and others added 5 commits August 2, 2019 11:33
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
client/lcd/swagger-ui/swagger.yaml Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 451535b into master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants