Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offline flag description #5114

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 30, 2019

replaces: #5056
closes: #5053
credit: @wangkui0508


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #5114 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5114      +/-   ##
==========================================
- Coverage   54.86%   54.85%   -0.02%     
==========================================
  Files         295      295              
  Lines       18261    18261              
==========================================
- Hits        10019    10017       -2     
- Misses       7493     7495       +2     
  Partials      749      749

@alexanderbez alexanderbez merged commit d010b68 into master Sep 30, 2019
@alexanderbez alexanderbez deleted the bez/fix-tx-sign-flag-descr branch September 30, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Typo in "sign [file]"
2 participants