RecheckTx Optimizations #5196
Merged
RecheckTx Optimizations #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
|
@AdityaSripal tests are failing |
alexanderbez
suggested changes
Oct 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #5196 +/- ##
==========================================
- Coverage 53.55% 53.54% -0.02%
==========================================
Files 290 290
Lines 17719 17738 +19
==========================================
+ Hits 9489 9497 +8
- Misses 7489 7502 +13
+ Partials 741 739 -2 |
golangcibot
reviewed
Oct 15, 2019
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
alexanderbez
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Looks good @AdityaSripal. Take a look at @fedekunze's comments
fedekunze
reviewed
Oct 22, 2019
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
fedekunze
approved these changes
Oct 23, 2019
| runTxModeSimulate runTxMode = iota | ||
| // Deliver a transaction | ||
| runTxModeDeliver runTxMode = iota | ||
| runTxModeCheck runTxMode = iota // Check a transaction |
There was a problem hiding this comment.
Suggested change
| runTxModeCheck runTxMode = iota // Check a transaction | |
| runTxModeCheck runTxMode = iota + 1 // Check a transaction |
There was a problem hiding this comment.
why? This is ineffectual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4933
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: