Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrise simulation gas value #5419

Merged
merged 7 commits into from
Dec 18, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 17, 2019

Reported by @migueldingli1997


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

simapp/helpers/test_helpers.go Outdated Show resolved Hide resolved
@fedekunze fedekunze changed the title Parametrise simapp/helpers.GenTx()'s gas value Parametrise simulation gas value Dec 17, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #5419 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5419      +/-   ##
==========================================
- Coverage    54.6%   54.59%   -0.01%     
==========================================
  Files         315      315              
  Lines       18919    18921       +2     
==========================================
  Hits        10330    10330              
- Misses       7808     7810       +2     
  Partials      781      781
Impacted Files Coverage Δ
simapp/test_helpers.go 0% <0%> (ø) ⬆️

@alexanderbez alexanderbez merged commit eae10b0 into master Dec 18, 2019
@alexanderbez alexanderbez deleted the alessio/parametrise-simulation-gentx branch December 18, 2019 14:48
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants