-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 003 follow-up #5469
Merged
alexanderbez
merged 5 commits into
master
from
cwgoes/adr-dynamic-capability-store-follow-up
Jan 5, 2020
Merged
ADR 003 follow-up #5469
alexanderbez
merged 5 commits into
master
from
cwgoes/adr-dynamic-capability-store-follow-up
Jan 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may also result in making capabilities multi-owner, at least for now, that seems cleaner. |
cwgoes
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
January 4, 2020 20:04
fedekunze
approved these changes
Jan 4, 2020
Closed
Codecov Report
@@ Coverage Diff @@
## master #5469 +/- ##
==========================================
+ Coverage 54.41% 54.46% +0.04%
==========================================
Files 313 313
Lines 18854 18892 +38
==========================================
+ Hits 10259 10289 +30
- Misses 7808 7812 +4
- Partials 787 791 +4
|
alexanderbez
approved these changes
Jan 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5416; see details on that issue.
For admin use:
WIP
,R4R
,docs
, etc)