Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 003 follow-up #5469

Merged
merged 5 commits into from
Jan 5, 2020
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jan 2, 2020

Closes #5416; see details on that issue.


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added T:Docs Changes and features related to documentation. feature labels Jan 2, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 2, 2020

  • Local mapping from memory address to name in scoped capability keeper
  • Local mapping from name to index in scoped capability keeper
  • Authenticate uses local mapping
  • Global mapping from index to capability that can be used to claim capabilities

@cwgoes
Copy link
Contributor Author

cwgoes commented Jan 4, 2020

This may also result in making capabilities multi-owner, at least for now, that seems cleaner.

@cwgoes cwgoes marked this pull request as ready for review January 4, 2020 20:04
@cwgoes cwgoes added the R4R label Jan 4, 2020
@cwgoes cwgoes mentioned this pull request Jan 4, 2020
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #5469 into master will increase coverage by 0.04%.
The diff coverage is 72.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5469      +/-   ##
==========================================
+ Coverage   54.41%   54.46%   +0.04%     
==========================================
  Files         313      313              
  Lines       18854    18892      +38     
==========================================
+ Hits        10259    10289      +30     
- Misses       7808     7812       +4     
- Partials      787      791       +4
Impacted Files Coverage Δ
types/decimal.go 77.61% <71.05%> (+0.08%) ⬆️
types/int.go 75.59% <80%> (+0.27%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit e77496f into master Jan 5, 2020
@alexanderbez alexanderbez deleted the cwgoes/adr-dynamic-capability-store-follow-up branch January 5, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADR 003 follow-up
3 participants