Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf Introduction + Types #5491

Merged
merged 36 commits into from
Jan 24, 2020
Merged

Protobuf Introduction + Types #5491

merged 36 commits into from
Jan 24, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 7, 2020 •
edited
Loading

Description

  • Cleaning up/restructure of Makefile(s)
  • Addition of buf tooling
  • Migrating /types to protobuf
    • Coin
    • DecCoin
    • Implement CustomProtoType for Int, Uint, and Dec (to allow gogo proto's customtype)
  • CI updates

ref: #5444

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP C:Types T: State Machine Breaking State machine breaking changes (impacts consensus). C:Encoding labels Jan 7, 2020
golangcibot
golangcibot reviewed Jan 7, 2020
View reviewed changes
types/proto.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez added R4R and removed WIP labels Jan 8, 2020
@alexanderbez alexanderbez marked this pull request as ready for review January 8, 2020 15:04
aaronc
aaronc approved these changes Jan 8, 2020
View reviewed changes
buf.yaml
- FILE_LOWER_SNAKE_CASE
except:
- UNARY_RPC
- COMMENT_FIELD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually lean towards requiring field comments, but maybe it will make migration slower...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but it'll be super tedious. We don't even do this for standard go types.

buf.yaml
- COMMENTS
- FILE_LOWER_SNAKE_CASE
except:
- UNARY_RPC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any use case for streaming RPC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't atm.

types/proto.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Pending CI passing

alexanderbez
alexanderbez commented Jan 8, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Jan 9, 2020
Closed
@alexanderbez
Copy link
Contributor Author

Will wait to get this merged until after v0.38 is released in case we need to get last-minute changes into master.

@aaronc, the change from bytes to string for amount causes build errors and does not work as -is.

@sahith-narahari sahith-narahari mentioned this pull request Jan 16, 2020
Closed
11 tasks
@alexanderbez alexanderbez mentioned this pull request Jan 16, 2020
Merged
12 tasks
aaronc
aaronc reviewed Jan 16, 2020
View reviewed changes
codec/types.go Outdated Show resolved Hide resolved
@alessio alessio mentioned this pull request Jan 17, 2020
Closed
@codecov
Copy link

codecov bot commented Jan 21, 2020 •
edited
Loading

Codecov Report

Merging #5491 into master will decrease coverage by 0.41%.
The diff coverage is 44.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5491      +/-   ##
==========================================
- Coverage   53.42%   53.01%   -0.42%     
==========================================
  Files         316      319       +3     
  Lines       19378    19560     +182     
==========================================
+ Hits        10352    10369      +17     
- Misses       8226     8379     +153     
- Partials      800      812      +12
Impacted Files Coverage Δ
x/upgrade/module.go 42.22% <ø> (ø) ⬆️
x/upgrade/abci.go 100% <ø> (ø) ⬆️
x/distribution/types/params.go 0% <ø> (ø) ⬆️
store/types/store.go 43.75% <ø> (ø) ⬆️
x/staking/abci.go 50% <ø> (ø) ⬆️
codec/hybrid_codec.go 0% <0%> (ø)
store/prefix/store.go 86.36% <0%> (-4.12%) ⬇️
simapp/app.go 89.5% <0%> (ø) ⬆️
store/tracekv/store.go 90.62% <0%> (-2.93%) ⬇️
store/gaskv/store.go 72.46% <0%> (-2.17%) ⬇️
... and 39 more

golangcibot
golangcibot reviewed Jan 21, 2020
View reviewed changes
codec/codec.go Outdated Show resolved Hide resolved
codec/amino_codec_test.go Show resolved Hide resolved
codec/amino_codec_test.go Show resolved Hide resolved
codec/amino_codec_test.go Show resolved Hide resolved
golangcibot
golangcibot reviewed Jan 21, 2020
View reviewed changes
codec/amino_codec_test.go Show resolved Hide resolved
codec/codec.go Outdated Show resolved Hide resolved
aaronc
aaronc approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for all your hard work on this. Excited to get it merged in!

@alexanderbez alexanderbez merged commit 26d6e49 into master Jan 24, 2020
@tac0turtle tac0turtle deleted the bez/5444-types-proto-enc branch March 4, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@tac0turtle tac0turtle tac0turtle left review comments

@fedekunze fedekunze fedekunze approved these changes

@aaronc aaronc aaronc approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
C:Encoding C:Types T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderbez @aaronc @tac0turtle @fedekunze @golangcibot