ensure non-nil gentxs #5497
Merged
ensure non-nil gentxs #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbarraford
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
alessio
previously requested changes
Jan 9, 2020
|
added tests. |
fedekunze
approved these changes
Jan 9, 2020
alexanderbez
suggested changes
Jan 9, 2020
|
added changelog entry. |
cbarraford
force-pushed
the
5086-issue
branch
from
fae7b4a
to
b24af20
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Are there any other blockers to this PR merging? |
alexanderbez
suggested changes
Feb 10, 2020
CHANGELOG.md
Outdated
| @@ -250,6 +250,8 @@ to detail this new feature and how state transitions occur. | |||
| * (keys) Fix ledger custom coin type support bug | |||
| * (x/gov) [\#5107](https://github.com/cosmos/cosmos-sdk/pull/5107) Sum validator operator's all voting power when tally votes | |||
| * (rest) [\#5212](https://github.com/cosmos/cosmos-sdk/issues/5212) Fix pagination in the `/gov/proposals` handler. | |||
| * (genesis) [\#5086](https://github.com/cosmos/cosmos-sdk/issues/5086) Ensure | |||
There was a problem hiding this comment.
Changes look good, however, we've released a version since this PR. So we need to move this entry up to the Unreleased section.
|
Looks good @cbarraford -- sorry for the delay! All we need to do is fix the changelog and we can merge 👍 |
cbarraford
force-pushed
the
5086-issue
branch
from
e004b3c
to
a5e469f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5497 +/- ##
==========================================
- Coverage 44.64% 44.64% -0.01%
==========================================
Files 324 324
Lines 24707 24709 +2
==========================================
Hits 11031 11031
- Misses 12616 12618 +2
Partials 1060 1060
|
|
Ok, done. |
alexanderbez
pushed a commit
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5086
Description
Ensure we never have
nullin our genesis for gentxs.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)