-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Int and Dec to string's on Coin and DecCoin proto types #5505
Convert Int and Dec to string's on Coin and DecCoin proto types #5505
Conversation
Codecov Report
@@ Coverage Diff @@
## bez/5444-types-proto-enc #5505 +/- ##
===========================================================
- Coverage 53.5% 53.5% -0.01%
===========================================================
Files 314 314
Lines 19317 19319 +2
===========================================================
Hits 10336 10336
- Misses 8185 8187 +2
Partials 796 796
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proto changes look good. Please revert everything else 👍
.gitignore
Outdated
@@ -10,7 +10,6 @@ | |||
*.pyc | |||
|
|||
# Build | |||
vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that because otherwise I had no idea vendor was messing up protoc. I can revert, but if anyone else runs go mod vendor
they'll have problems.
go.mod
Outdated
@@ -15,6 +15,7 @@ require ( | |||
github.com/pelletier/go-toml v1.6.0 | |||
github.com/pkg/errors v0.8.1 | |||
github.com/rakyll/statik v0.1.6 | |||
github.com/regen-network/cosmos-proto v0.0.0-20200110230910-60122eba6250 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo. Instead, update the protoc-gen-gocosmos
target to install a specific version:
protoc-gen-gocosmos:
@(cd /tmp && github.com/regen-network/cosmos-proto/protoc-gen-gocosmos@VERSION)
We cd into tmp
to not pollute go.mod
-- hacky, but idk another way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)