-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min-height and max-height filters to TxSearch #5648
Add min-height and max-height filters to TxSearch #5648
Conversation
I'm not sure if I should add doc in any I definitely did not check if my const are correct regarding GoDoc, I'll do this hopefully before monday. I definitely did not add changelog, but I'll make it if you're okay with the key I chose I didn't write tests, I just wanted to check the changes in my local client but it's still syncing. Any pointers for test writing is welcome |
3a8d956
to
5f762c9
Compare
I don't understand why the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK -- Thanks @gagbo!
WRT to proto
, don't worry about this. The issue is due to the fact that the PR is from a forked remote. We should probably look into how to fix that.
Closes: #5638
Description
Allow REST server to allow clients to query for a minimum and/or maximum height in transactions
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)