Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Fee Delegation #5768

Closed
wants to merge 85 commits into from
Closed

Enable Fee Delegation #5768

wants to merge 85 commits into from

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 9, 2020

TODO:

  • Address any remaining issues from original PR
  • Proto Updates
  • Verfiy docs + spec are in order
  • Fix CI (issues with ante-handler/txs)

replaces: #5207

/cc @aaronc @ethanfrey


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Jun 4, 2020

The concept seems fine, but would an ADR be helpful here, perhaps? Finding a (vague) spec requires going back several PRs to a comment in #4616.

@aaronc
Copy link
Member

aaronc commented Jun 4, 2020

The concept seems fine, but would an ADR be helpful here, perhaps? Finding a (vague) spec requires going back several PRs to a comment in #4616.

An ADR does make sense. I will try to get to it at some point soon... There's a lot of other stuff on my plate at present. Unless someone else wants to write one....

@alexanderbez
Copy link
Contributor Author

@clevinson we may have to consider punting this 0.40. Thoughts @aaronc?

@aaronc
Copy link
Member

aaronc commented Jun 25, 2020

@clevinson we may have to consider punting this 0.40. Thoughts @aaronc?

Unfortunately we may need to do that... Although obviously that would be pretty disappointing for stakeholders who have been waiting already a long time for subkeys functionality.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 6, 2020
@aaronc aaronc added pinned and removed stale labels Jul 6, 2020
@alexanderbez alexanderbez removed the WIP label Jul 7, 2020
@alexanderbez alexanderbez modified the milestones: v0.40 [Stargate], v0.41 Jul 21, 2020
@aaronc aaronc mentioned this pull request Aug 17, 2020
4 tasks
@aaronc aaronc mentioned this pull request Sep 30, 2020
9 tasks
@atheeshp atheeshp closed this Feb 1, 2021
@aaronc aaronc removed the in progress label Feb 1, 2021
@atheeshp
Copy link
Contributor

atheeshp commented Feb 1, 2021

closed in favour of #8061

@alessio alessio deleted the bez/enable-fee-auth branch March 14, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants