crypto/keys/mintkey: fix errors handling in UnarmorPubKeyBytes #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
force-pushed
the
alessio/mintkey-bytes-armoring-unhandled-errors
branch
from
86e196f
to
7c2b4a7
Compare
Check error returned by internal call to unarmorBytes() and handle accordingly. Handle empty version field adequately.
alessio
force-pushed
the
alessio/mintkey-bytes-armoring-unhandled-errors
branch
from
8171fac
to
98dc194
Compare
alessio
requested review from
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5823 +/- ##
==========================================
+ Coverage 32.49% 32.51% +0.01%
==========================================
Files 346 346
Lines 39012 39016 +4
==========================================
+ Hits 12678 12685 +7
+ Misses 25066 25064 -2
+ Partials 1268 1267 -1 |
tac0turtle
reviewed
Mar 18, 2020
alexanderbez
pushed a commit
that referenced
this pull request
Mar 24, 2020
Check error returned by internal call to unarmorBytes() and handle accordingly. Handle header's empty version field adequately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check error returned by internal call to unarmorBytes()
and handle accordingly.
Handle empty version field adequately.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)