Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring overhaul - take #1 #5879

Merged

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 26, 2020

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the WIP label Mar 26, 2020
@jgimeno jgimeno changed the title Starting creating refactored keyring Starting creating refactored keyring [WIP] Mar 26, 2020
crypto/keyring/altkeyring_test.go Outdated Show resolved Hide resolved
crypto/keyring/altkeyring.go Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor

@jgimeno just a heads up, next time try and create a PR as a Draft please 👍

@jgimeno
Copy link
Contributor Author

jgimeno commented Mar 27, 2020

yeah! It was supposed to be a super short PR merged to alessio's branch.

@jgimeno jgimeno requested a review from jaekwon April 1, 2020 01:05
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #5879 into alessio/new-keyring-interface will not change coverage by %.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           alessio/new-keyring-interface    #5879   +/-   ##
==============================================================
  Coverage                          57.05%   57.05%           
==============================================================
  Files                                344      344           
  Lines                              20329    20329           
==============================================================
  Hits                               11599    11599           
  Misses                              7841     7841           
  Partials                             889      889           

@alessio alessio merged commit fd74489 into alessio/new-keyring-interface Apr 1, 2020
@alessio alessio deleted the jonathan/keyring-refactor-interface branch April 1, 2020 14:48
@alessio alessio changed the title Starting creating refactored keyring [WIP] Keyring overhaul - take #1 Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants