-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyring overhaul - take #1 #5879
Merged
alessio
merged 68 commits into
alessio/new-keyring-interface
from
jonathan/keyring-refactor-interface
Apr 1, 2020
Merged
Keyring overhaul - take #1 #5879
alessio
merged 68 commits into
alessio/new-keyring-interface
from
jonathan/keyring-refactor-interface
Apr 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgimeno
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
March 26, 2020 20:56
jgimeno
changed the title
Starting creating refactored keyring
Starting creating refactored keyring [WIP]
Mar 26, 2020
golangcibot
reviewed
Mar 26, 2020
golangcibot
reviewed
Mar 26, 2020
@jgimeno just a heads up, next time try and create a PR as a Draft please 👍 |
yeah! It was supposed to be a super short PR merged to alessio's branch. |
golangcibot
reviewed
Mar 27, 2020
golangcibot
reviewed
Mar 27, 2020
golangcibot
reviewed
Mar 27, 2020
golangcibot
reviewed
Mar 27, 2020
…os/cosmos-sdk into jonathan/keyring-refactor-interface
alessio
reviewed
Mar 31, 2020
alessio
reviewed
Mar 31, 2020
golangcibot
reviewed
Mar 31, 2020
alessio
reviewed
Mar 31, 2020
alessio
reviewed
Mar 31, 2020
golangcibot
reviewed
Mar 31, 2020
This reverts commit dbeea70.
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## alessio/new-keyring-interface #5879 +/- ##
==============================================================
Coverage 57.05% 57.05%
==============================================================
Files 344 344
Lines 20329 20329
==============================================================
Hits 11599 11599
Misses 7841 7841
Partials 889 889 |
alessio
changed the title
Starting creating refactored keyring [WIP]
Keyring overhaul - take #1
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)