Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge crypto/keys/mintkey into crypto/ #5880

Merged
merged 2 commits into from
Mar 27, 2020
Merged

merge crypto/keys/mintkey into crypto/ #5880

merged 2 commits into from
Mar 27, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 26, 2020

crypto/keys/mintkey provides only armoring functions.
It makes very little sense to keep it standalone and
under a name which does not really seem consistent with
the features it provides.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the WIP label Mar 26, 2020
crypto/keys/mintkey provides only armoring functions.
It makes very little sense to keep it standalone and
under a name which does not really seem consistent with
the features it provides.
@alessio alessio force-pushed the alessio/move-mintkey branch from 0bbefc4 to 294a31d Compare March 26, 2020 21:49
@alessio alessio marked this pull request as ready for review March 26, 2020 21:49
@alessio alessio requested review from jgimeno and tac0turtle March 26, 2020 21:49
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5880 into master will not change coverage.
The diff coverage is 94.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5880   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files         344      344           
  Lines       20294    20294           
=======================================
  Hits        11514    11514           
  Misses       7899     7899           
  Partials      881      881
Impacted Files Coverage Δ
crypto/armor.go 87.5% <ø> (ø)
crypto/keyring/keyring.go 51.91% <100%> (ø) ⬆️
crypto/keyring/db_keybase.go 66.13% <90.9%> (ø) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio merged commit 5db6d54 into master Mar 27, 2020
@alessio alessio deleted the alessio/move-mintkey branch March 27, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants