-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types/rest: convenience functions for error checking #5900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5900 +/- ##
==========================================
+ Coverage 56.99% 57.04% +0.05%
==========================================
Files 342 342
Lines 20060 20056 -4
==========================================
+ Hits 11433 11441 +8
+ Misses 7782 7770 -12
Partials 845 845 |
8225058
to
c0455fe
Compare
c0455fe
to
9457da7
Compare
9457da7
to
7e2476c
Compare
A way to make people use this can be to update the scaffold tool here: https://github.com/cosmos/scaffold/blob/master/templates/module/client/rest/query.go.tmpl if not I think will be difficult for people to discover this function exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jgimeno keep in mind, a large part of that REST boostrapping logic will change with gRPC/Proto. See ADR 021. |
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)