Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate verifier when --trust-node is off #5986

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 13, 2020

Maintenance release:


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added WIP and removed R4R labels Apr 13, 2020
@alessio alessio added R4R and removed WIP labels Apr 13, 2020
@alessio alessio changed the title instantiate verifier when --trust-node is on instantiate verifier when --trust-node is off Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #5986 into rc0/v0.37.10 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           rc0/v0.37.10    #5986      +/-   ##
================================================
- Coverage         51.36%   51.35%   -0.02%     
================================================
  Files               290      290              
  Lines             18900    18900              
================================================
- Hits               9708     9706       -2     
- Misses             8499     8501       +2     
  Partials            693      693              

@alessio alessio requested a review from tac0turtle April 13, 2020 14:35
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessio does this same problem exist on master? If so, we should have this target master instead of an RC branch.

@alessio
Copy link
Contributor Author

alessio commented Apr 13, 2020

@alexanderbez I cannot reproduce the same problem on master. Though we have a different one there (the use of IsSet()). I'm working on that too

@alexanderbez
Copy link
Contributor

Ok, cool. I would hesitate to release a point release with just one "entry" -- too much operational burden. I would recommend till we have a few more things we can add to make it worth it.

@alessio alessio merged commit 16c2038 into rc0/v0.37.10 Apr 21, 2020
@alessio alessio deleted the fix-panic-if-trust-node-is-off branch April 21, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants