-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consensus params into Simulation #6002
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
752859c
temporal commit
jgimeno 4b61cd1
add random consensus params
jgimeno 351069a
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno bfbd275
make format
jgimeno ef06bbc
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno e734a7f
make random pass
jgimeno ede19d9
remove comment
jgimeno c275138
revert change
jgimeno b1a3403
update ub key types
jgimeno 42b4c70
extract Evidence params from state
jgimeno d2382c9
extract the random parameters from state
jgimeno 2f36081
clean the code
jgimeno cdcb9e9
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno af3c2fc
update imports!
jgimeno 2b98aff
mispelled back
jgimeno d1d3355
mispelled back
jgimeno 0e9ec1b
add misspelled command
jgimeno 4125431
update changelog
jgimeno 84341c8
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno d09de06
remove useless linter to avoid misspell
jgimeno 2b3a6f3
Merge branch 'master' into jonathan/5988-sim-params-consensus
alexanderbez 6c0e4ff
remove function
jgimeno 2e52fcf
use tendermint constants
jgimeno fc895f0
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno 6cf3eb0
Merge branch 'master' into jonathan/5988-sim-params-consensus
jgimeno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this even called/used? I'd opt to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah in x/simulation/params.go line 182
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so you removed the other, now removed private helper function 👍