-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge x/supply into x/bank #6010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
T: State Machine Breaking
State machine breaking changes (impacts consensus).
C:x/bank
x/supply
labels
Apr 16, 2020
fedekunze
reviewed
Apr 16, 2020
aaronc
reviewed
Apr 17, 2020
golangcibot
reviewed
Apr 17, 2020
alexanderbez
requested review from
jgimeno,
tac0turtle,
fedekunze,
aaronc and
AdityaSripal
April 17, 2020 18:55
fedekunze
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
…-sdk into bez/5913-remove-supply-mod
jgimeno
reviewed
Apr 20, 2020
utACK |
Co-Authored-By: Jonathan Gimeno <jgimeno@gmail.com>
4 tasks
9 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:x/bank
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
T: State Machine Breaking
State machine breaking changes (impacts consensus).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x/supply
intox/bank
x/auth
, but that should be completed in a follow up PR.As for reviewing this PR, no critical business logic or state-machine changes were made. Types and APIs were simply moved.
closes: #5913
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)