-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor simulation decoder #6037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Codecov Report
@@ Coverage Diff @@
## master #6037 +/- ##
==========================================
- Coverage 54.65% 54.63% -0.03%
==========================================
Files 424 424
Lines 25820 25834 +14
==========================================
+ Hits 14113 14115 +2
- Misses 10736 10742 +6
- Partials 971 977 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There looks to be issues with the |
@alexanderbez If you're ok, I'd suggest merging this since the bug is from #6002 and this PR's changes are unrelated |
Closes: #5664
Description
cc: @alexanderbez
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)