Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CoinType from config as the default coin type #6038

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

sorawit
Copy link
Contributor

@sorawit sorawit commented Apr 21, 2020

Closes: n/a. We ran into this issue after #5904 was landed.

Description

In BandChain, we use hardware prefix 494 for BAND token. We want the keyring command to respect the config we set and use 494 as the default value in our case. Otherwise, users will need to put --coin-type all the time.

Proof that this PR works: The following is part of what we get from bandcli keys add --help. You can see that the default is not 494. Before the change it was 118.

Screen Shot 2020-04-21 at 15 27 39

______

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio
Copy link
Contributor

alessio commented Apr 21, 2020

I see your point, though this PR would reintroduce a dependency on the sdk.Config singleton.
I believe CoinType should be a var in types that could be customised via build flags

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it back - it's out of scope of this PR to solve the sdk.Config conundrum.
ACK from me.

@alexanderbez alexanderbez merged commit 80247dd into cosmos:master Apr 21, 2020
@alexanderbez alexanderbez mentioned this pull request Apr 21, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants