x/auth/ante: AccountKeeper expected interface used instead of the str… #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict auth.AccountKeeper dependency
iTiky
requested review from
alessio,
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6040 +/- ##
=========================================
Coverage ? 54.71%
=========================================
Files ? 424
Lines ? 25794
Branches ? 0
=========================================
Hits ? 14113
Misses ? 10710
Partials ? 971 |
alexanderbez
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
ACK. Great stuff @iTiky. Thank you so much. Do you mind rebasing latest master and I'll get this merged ASAP.
alexanderbez
added
the
A:automerge
fedekunze
approved these changes
Apr 21, 2020
alexanderbez
removed
the
A:automerge
|
@alexanderbez @fedekunze Done |
fedekunze
added
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds AccountKeeper interface to be used as an input by
AnteHandler's decorators. That makes possible for Cosmos-SDK based projects to use custom / extendedAccountKeeperimplementation and avoid decorators source code copy (ability to reuse code).For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)