ibc/02-client: import export GenesisState #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
commented
Apr 24, 2020
x/ibc/02-client/genesis.go
Outdated
Comment on lines
14
to
19
| for _, cs := range gs.ClientsConsensus { | ||
| for _, consState := range cs.ConsensusStates { | ||
| // TODO: double-check if the consState will be invalidated on import at 0 height. | ||
| k.SetClientConsensusState(ctx, cs.ClientID, consState.GetHeight(), consState) | ||
| } | ||
| } |
There was a problem hiding this comment.
@cwgoes @AdityaSripal what happens in the case of a zero height export? should I just set one consensus state (the one w/ latest height) at height 0?
There was a problem hiding this comment.
This is a client of another chain, why would we change the logic on a zero-height export?
In any case, we should stop doing zero-height exports anyways once IBC is operational.
Codecov Report
@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
+ Coverage 54.43% 54.60% +0.16%
==========================================
Files 431 435 +4
Lines 26156 26284 +128
==========================================
+ Hits 14239 14352 +113
- Misses 10930 10940 +10
- Partials 987 992 +5 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…import-export-ibc-pt-2
fedekunze
requested review from
alessio,
alexanderbez,
hschoenburg and
nylira
as code owners
fedekunze
commented
Apr 27, 2020
| @@ -33,10 +33,10 @@ func defaultIdentifierValidator(id string, min, max int) error { | |||
| } | |||
|
|
|||
| // DefaultClientIdentifierValidator is the default validator function for Client identifiers | |||
| // A valid Identifier must be between 10-20 characters and only contain lowercase | |||
| // A valid Identifier must be between 9-20 characters and only contain lowercase | |||
There was a problem hiding this comment.
I had to change this because "localhost" has len 9
…cosmos-sdk into fedekunze/import-export-ibc-pt-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5948
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)