Add CLI tests for simd, distribution

[sahith-narahari]

Reference - #5951

Description

This PR adds tests for simd cli commands and distribution commands

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[alessio]

Brilliant, thanks!

Tests are failing

[alessio]

Tests failed again:

--- FAIL: TestValidateGenesis (0.00s)
    gobash.go:60: Running simd --home=/tmp/sdk_integration_TestValidateGenesis_897338208/.simd unsafe-reset-all
    gobash.go:72: 
        	Error Trace:	gobash.go:72
        	            				executors.go:22
        	            				executors.go:17
        	            				helpers.go:47
        	            				init.go:18
        	            				simd_test.go:118
        	Error:      	Received unexpected error:
        	            	exec: "simd": executable file not found in $PATH
        	Test:       	TestValidateGenesis

[alessio]

Left few suggestions. I'm also attaching a patch to fix the issue - I hope this helps:

commit a64ecea3c67c4fde234b092a29627279e2a4af41
Author: Alessio Treglia <alessio@tendermint.com>
Date:   Fri May 1 01:45:01 2020 +0200

    skip tests if builddir is empty

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 92ffad089..2621695fb 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -35,7 +35,7 @@ jobs:
         if: "env.GIT_DIFF != ''"
       - name: test & coverage report creation
         run: |
-          go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock cli_test'
+          go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock cli_test' -builddir=./build/
         if: "env.GIT_DIFF != ''"
       - name: filter out DONTCOVER
         run: |
diff --git a/Makefile b/Makefile
index 0e0876afb..7bdb9ae0f 100644
--- a/Makefile
+++ b/Makefile
@@ -169,8 +169,8 @@ test-sim-benchmark-invariants:
 	-Period=1 -Commit=true -Seed=57 -v -timeout 24h
 
 cli-test: build-sim
-	@go test -mod=readonly -p 4 `go list ./tests/cli/...` -tags=cli_test -v
-	@go test -mod=readonly -p 4 `go list ./x/.../client/cli_test/...` -tags=cli_test -v
+	go test -mod=readonly -p 4 `go list ./tests/cli/...` -tags=cli_test -v -builddir=$(BUILDDIR)
+	go test -mod=readonly -p 4 `go list ./x/.../client/cli_test/...` -tags=cli_test -v -builddir=$(BUILDDIR)
 
 .PHONY: \
 test-sim-nondeterminism \
diff --git a/tests/cli/fixtures.go b/tests/cli/fixtures.go
index 5df955a72..4fb8e74f6 100644
--- a/tests/cli/fixtures.go
+++ b/tests/cli/fixtures.go
@@ -1,8 +1,8 @@
 package cli
 
 import (
+	"flag"
 	"io/ioutil"
-	"os"
 	"path/filepath"
 	"testing"
 
@@ -16,7 +16,10 @@ import (
 	"github.com/cosmos/cosmos-sdk/simapp"
 )
 
-var cdc = std.MakeCodec(simapp.ModuleBasics)
+var (
+	cdc      = std.MakeCodec(simapp.ModuleBasics)
+	buildDir = flag.String("builddir", "", "Build directory")
+)
 
 // Fixtures is used to setup the testing environment
 type Fixtures struct {
@@ -45,15 +48,16 @@ func NewFixtures(t *testing.T) *Fixtures {
 	p2pAddr, _, err := server.FreeTCPAddr()
 	require.NoError(t, err)
 
-	buildDir := os.Getenv("BUILDDIR")
-	require.NotNil(t, buildDir)
+	if *buildDir == "" {
+		t.Skip("builddir is empty, skipping")
+	}
 
 	return &Fixtures{
 		T:            t,
-		BuildDir:     buildDir,
+		BuildDir:     *buildDir,
 		RootDir:      tmpDir,
-		SimdBinary:   filepath.Join(buildDir, "simd"),
-		SimcliBinary: filepath.Join(buildDir, "simcli"),
+		SimdBinary:   filepath.Join(*buildDir, "simd"),
+		SimcliBinary: filepath.Join(*buildDir, "simcli"),
 		SimdHome:     filepath.Join(tmpDir, ".simd"),
 		SimcliHome:   filepath.Join(tmpDir, ".simcli"),
 		RPCAddr:      servAddr,

[alessio]

Suggested change

	go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock cli_test'
	go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock cli_test' -builddir=`pwd`/build

[codecov]

Codecov Report

Merging #6095 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6095   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         443      443           
  Lines       26666    26666           
=======================================
  Hits        14568    14568           
  Misses      11101    11101           
  Partials      997      997           

[alessio]

Good to go