Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli tests for auth module #6096

Closed

Conversation

sahith-narahari
Copy link
Contributor

Reference - #5951

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

sahith-narahari and others added 30 commits April 15, 2020 03:57
…esh/cli-test-send

# Conflicts:
#	cli_test/tests/staking_test.go
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #6096 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6096   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files         442      442           
  Lines       26659    26659           
=======================================
  Hits        14566    14566           
  Misses      11095    11095           
  Partials      998      998           

@sahith-narahari sahith-narahari marked this pull request as ready for review May 1, 2020 21:32
@sahith-narahari
Copy link
Contributor Author

@alessio would you like me to address moving keys_test to client/keys in this PR or next one, anything works for me

@alessio
Copy link
Contributor

alessio commented May 1, 2020

@sahith-narahari no probs

@sahith-narahari sahith-narahari marked this pull request as draft May 2, 2020 12:19
@clevinson clevinson added this to the v0.39 milestone May 4, 2020
@sahith-narahari
Copy link
Contributor Author

Closing this as the changes have been included in #6108

@alessio
Copy link
Contributor

alessio commented May 5, 2020

Hold on, I think i misled you, I've just realised that not all test cases were included in #6108. Please reopen this one

@sahith-narahari
Copy link
Contributor Author

Thanks for the heads up, I'll raise a seperate PR with necessary additions. This branch is old and will have too many conflicts imo

@sahith-narahari
Copy link
Contributor Author

Thanks for the heads up, I'll raise a seperate PR with necessary additions. This branch is old and will have too many conflicts imo
#6152

@sahith-narahari sahith-narahari deleted the sahith/add-auth-tests branch May 15, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants