Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli test for slashing #6102

Merged
merged 80 commits into from
May 5, 2020
Merged

Conversation

sahith-narahari
Copy link
Contributor

Reference: #5951

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

sahith-narahari and others added 30 commits April 15, 2020 03:57
…esh/cli-test-send

# Conflicts:
#	cli_test/tests/staking_test.go
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #6102 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6102   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files         439      439           
  Lines       26501    26501           
=======================================
  Hits        14537    14537           
  Misses      10964    10964           
  Partials     1000     1000           

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/slashing/client/testutil/helpers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny bit left

@alessio alessio merged commit 7e72e5b into cosmos:master May 5, 2020
@sahith-narahari sahith-narahari deleted the sahith/add-slash-tests branch May 5, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants