-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP implement solo machine client #6115
WIP implement solo machine client #6115
Conversation
This pull request introduces 1 alert when merging c993f95 into f92f6c9 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging c7e2b38 into 1db967b - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #6115 +/- ##
==========================================
- Coverage 54.87% 54.44% -0.44%
==========================================
Files 446 454 +8
Lines 26976 27285 +309
==========================================
+ Hits 14802 14854 +52
- Misses 11129 11387 +258
+ Partials 1045 1044 -1 |
…-solo-machine-client
const ( | ||
Tendermint ClientType = iota + 1 // 1 | ||
Localhost | ||
SoloMachine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally they should be sorted according to their ICS number imo
const ( | |
Tendermint ClientType = iota + 1 // 1 | |
Localhost | |
SoloMachine | |
const ( | |
SoloMachine ClientType = iota + 1 // 1 | |
Tendermint | |
Localhost |
closing in favor of using a branch on the sdk repo |
Closes: #5382
Description
needs rest of client_state_test and update_test + misbheaviour_test
if you wanna start browsing this work, verifyXYZ funcs and usage of a commitment Prefix/Proof (SignaturePrefix/SignatureProof) is the juiciest part
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)