Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP implement solo machine client #6115

Closed
wants to merge 19 commits into from
Closed

WIP implement solo machine client #6115

wants to merge 19 commits into from

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented May 1, 2020

Closes: #5382

Description

needs rest of client_state_test and update_test + misbheaviour_test

if you wanna start browsing this work, verifyXYZ funcs and usage of a commitment Prefix/Proof (SignaturePrefix/SignatureProof) is the juiciest part


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2020

This pull request introduces 1 alert when merging c993f95 into f92f6c9 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request introduces 2 alerts when merging c7e2b38 into 1db967b - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Expression has no effect

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #6115 into master will decrease coverage by 0.43%.
The diff coverage is 24.56%.

@@            Coverage Diff             @@
##           master    #6115      +/-   ##
==========================================
- Coverage   54.87%   54.44%   -0.44%     
==========================================
  Files         446      454       +8     
  Lines       26976    27285     +309     
==========================================
+ Hits        14802    14854      +52     
- Misses      11129    11387     +258     
+ Partials     1045     1044       -1     

Comment on lines 161 to +164
const (
Tendermint ClientType = iota + 1 // 1
Localhost
SoloMachine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally they should be sorted according to their ICS number imo

Suggested change
const (
Tendermint ClientType = iota + 1 // 1
Localhost
SoloMachine
const (
SoloMachine ClientType = iota + 1 // 1
Tendermint
Localhost

@colin-axner
Copy link
Contributor Author

closing in favor of using a branch on the sdk repo

@colin-axner colin-axner mentioned this pull request May 21, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICS 06: Solo machine client
2 participants