-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add string method to gas meter #6137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6137 +/- ##
==========================================
- Coverage 54.83% 54.82% -0.01%
==========================================
Files 439 439
Lines 26494 26498 +4
==========================================
Hits 14527 14527
- Misses 10970 10974 +4
Partials 997 997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sladuca!
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 🎉
Great job @Sladuca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes: #6128
Description
Implemented string methods for
basicGasMeter
andinfiniteGasMeter
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)