Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string method to gas meter #6137

Merged
merged 5 commits into from
May 4, 2020

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented May 4, 2020

Closes: #6128

Description

Implemented string methods for basicGasMeter and infiniteGasMeter


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • [n/a] Wrote unit and integration tests
  • [n/a] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [n/a] Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #6137 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6137      +/-   ##
==========================================
- Coverage   54.83%   54.82%   -0.01%     
==========================================
  Files         439      439              
  Lines       26494    26498       +4     
==========================================
  Hits        14527    14527              
- Misses      10970    10974       +4     
  Partials      997      997              

store/types/gas.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sladuca!

alexanderbez and others added 2 commits May 4, 2020 14:52
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

Great job @Sladuca

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label May 4, 2020
@mergify mergify bot merged commit 18890a2 into cosmos:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add String() method to GasMeter
4 participants