Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/keys/parse.go: honor config changes #6172

Merged
merged 1 commit into from
May 8, 2020

Conversation

boz
Copy link
Contributor

@boz boz commented May 8, 2020

keys parse uses the global configuration before
before client applications have had a chance to
apply their settings.

This change adds a GetSealedConfig() helper
that waits for the config to be sealed before
returning it.

fixes #5091
addresses #5283

@auto-comment
Copy link

auto-comment bot commented May 8, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #6172 into master will decrease coverage by 0.00%.
The diff coverage is 65.71%.

@@            Coverage Diff             @@
##           master    #6172      +/-   ##
==========================================
- Coverage   54.79%   54.79%   -0.01%     
==========================================
  Files         443      443              
  Lines       26704    26729      +25     
==========================================
+ Hits        14633    14645      +12     
- Misses      11032    11044      +12     
- Partials     1039     1040       +1     

`keys parse` uses the global configuration before
before client applications have had a chance to
apply their settings.

This change adds a `GetSealedConfig()` helper
that waits for the config to be sealed before
returning it.

fixes cosmos#5091
addresses cosmos#5283
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks @boz, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bench32Prefixes donnot change。
2 participants