Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement solo machine client #6267
implement solo machine client #6267
Changes from 86 commits
cbc16d7
e045498
c993f95
6de06a4
c7e2b38
fedb7c8
066d6b0
57c7ad5
f83c1d6
aa8703b
c70d6ec
5c31eda
dcb688b
d6de635
3463dc1
fa52816
c163056
9e30000
480aa6c
afbc501
11c5707
83805ca
d459d57
bc4b50a
8b2e924
43fb4a2
8032570
7aef9d4
9bebd1d
c7e521d
1bbd505
f1616b7
fbdb272
97728b8
89f5870
5d4e6c6
2b25840
992a28d
74a7120
4696f74
cf601c3
72b2cf1
4098179
d2426ed
bb493c9
7f6c19b
53c8875
eafa96c
6de9582
c08c5bb
2f57522
d9c106d
4fc1df8
d709936
03d63ae
317c1f1
572e5b9
d4151a1
925026a
05ca908
3789072
003d626
5893db8
f81dd48
955b0b2
31e6d56
776ae65
8b9d4fa
f71fdbb
c4b7fc5
1d48573
f733da7
4cb6b1a
9e6ea20
1dfaaa6
fb34b42
badfd61
76c303a
e3f8888
a2474b3
04e55eb
de84509
1f1f0f8
8a76254
7a0e730
34d15cf
3e85eae
2ac5fbe
329d769
159167b
e421c4f
f776e2f
c8dca75
8395379
7dfc425
60a1034
4f7d604
e939091
30f45c0
ffd3086
871a6a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this wouldn't make sense because we don't need the timestamp for
SignatureAndData
it is only used for misbehaviour. The naming still needs some work..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proof needs to be passed in as a
[]byte
but I need the actual signature and thetimestamp
so we have to marshal this struct and pass it in asproof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of renaming to
SignatureDoc
? since it isn't strictly just the signatureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change 👍