Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/auth: remove unused passphrase arguments #6270

Merged
merged 2 commits into from
May 22, 2020
Merged

x/auth: remove unused passphrase arguments #6270

merged 2 commits into from
May 22, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 22, 2020

The new keyring does not handle passphrases directly anymore.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@alessio alessio added the WIP label May 22, 2020
x/auth: remove unused passphrase arguments
23704ac 
The new keyring does not handle passphrases anymore.
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #6270 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6270   +/-   ##
=======================================
  Coverage   55.67%   55.67%           
=======================================
  Files         447      447           
  Lines       26867    26867           
=======================================
  Hits        14957    14957           
  Misses      10843    10843           
  Partials     1067     1067

@alessio alessio force-pushed the alessio/remove-passphrase branch from 8984d43 to 23704ac Compare May 22, 2020 10:14
@alessio alessio marked this pull request as ready for review May 22, 2020 10:15
@alessio alessio requested a review from tac0turtle May 22, 2020 10:15
tac0turtle
tac0turtle approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alexanderbez
alexanderbez approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 22, 2020
@mergify mergify bot merged commit 37882fb into master May 22, 2020
@mergify mergify bot deleted the alessio/remove-passphrase branch May 22, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@clevinson clevinson Awaiting requested review from clevinson

@fedekunze fedekunze Awaiting requested review from fedekunze

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @alexanderbez @tac0turtle