Change GetQueryCmd to take client.Context #6326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
added
T: API Breaking
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6326 +/- ##
=======================================
Coverage 55.66% 55.66%
=======================================
Files 448 448
Lines 26956 26956
=======================================
Hits 15005 15005
Misses 10877 10877
Partials 1074 1074 |
alessio
approved these changes
Jun 3, 2020
alexanderbez
suggested changes
Jun 3, 2020
| @@ -52,8 +52,8 @@ type AppModuleBasic interface { | |||
|
|
|||
| // client functionality | |||
| RegisterRESTRoutes(client.Context, *mux.Router) | |||
| GetTxCmd(client.Context) *cobra.Command | |||
| GetQueryCmd(*codec.Codec) *cobra.Command | |||
| GetTxCmd(clientCtx client.Context) *cobra.Command | |||
There was a problem hiding this comment.
nit the package and type suffice for context, no need to add a variable.
alexanderbez
added
the
A:automerge
alexanderbez
reviewed
Jun 3, 2020
| @@ -52,8 +52,8 @@ type AppModuleBasic interface { | |||
|
|
|||
| // client functionality | |||
| RegisterRESTRoutes(client.Context, *mux.Router) | |||
| GetTxCmd(client.Context) *cobra.Command | |||
| GetQueryCmd(*codec.Codec) *cobra.Command | |||
| GetTxCmd(clientCtx client.Context) *cobra.Command | |||
There was a problem hiding this comment.
Suggested change
| GetTxCmd(clientCtx client.Context) *cobra.Command | |
| GetTxCmd(client.Context) *cobra.Command |
alexanderbez
reviewed
Jun 3, 2020
| GetTxCmd(client.Context) *cobra.Command | ||
| GetQueryCmd(*codec.Codec) *cobra.Command | ||
| GetTxCmd(clientCtx client.Context) *cobra.Command | ||
| GetQueryCmd(clientCtx client.Context) *cobra.Command |
There was a problem hiding this comment.
Suggested change
| GetQueryCmd(clientCtx client.Context) *cobra.Command | |
| GetQueryCmd(client.Context) *cobra.Command |
There was a problem hiding this comment.
Adding the variable name is actually helpful when implementing the method using code completion because we wanted clientCtx rather than ctx. But I can remove it if you prefer
There was a problem hiding this comment.
Where would one get ctx from? I'd opt to remove it personally. Not blocking though, so proceed at your own discretion.
There was a problem hiding this comment.
Sorry it would be context. I'd prefer to keep it because it helped my IDE (goland) keep the style conventions from #6290.
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Change GetQueryCmd to take a client.Context * Update CHANGELOG Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5921
This makes
GetQueryCmdsimilar to the newGetTxCmdwhich also takesclient.Contextnow. It will be used for gRPC queriers.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer