Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cli tests for distr and mint #6349

Merged
merged 23 commits into from
Jun 11, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Jun 5, 2020

Description

This add missing tests for cli queries and transactions which are absent in gaia/cli_test
Reference - #5951

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6349 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6349      +/-   ##
==========================================
- Coverage   55.54%   55.54%   -0.01%     
==========================================
  Files         465      465              
  Lines       27514    27515       +1     
==========================================
  Hits        15284    15284              
- Misses      11132    11133       +1     
  Partials     1098     1098              

@atheeshp atheeshp changed the title Atheesh/missing cli tests Staking missing cli tests Jun 5, 2020
@atheeshp atheeshp changed the title Staking missing cli tests Missing cli tests Jun 8, 2020
@anilcse anilcse changed the title Missing cli tests Missing cli tests for distr and mint Jun 8, 2020
@atheeshp atheeshp marked this pull request as ready for review June 10, 2020 12:32
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
@alessio alessio added R4R and removed WIP labels Jun 11, 2020
@alessio alessio merged commit 4ecbd00 into master Jun 11, 2020
@alessio alessio deleted the atheesh/missing-cli-tests branch June 11, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/distribution distribution module related T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants