Migrate x/auth cmd's to TxGenerator marshaling #6391

aaronc · 2020-06-10T18:31:04Z

This is one of several bite-size PR's that are being pulled out of #6216 to implement #6213.

Summary

This PR makes incremental progress on migrating the remaining x/auth CLI commands to the new infrastructure for protobuf as well as setting the foundation for #6190.

Details

add TxEncoder|Decoder and TxJSONEncoder|Decoder methods to TxGenerator and remove Marshal method.
migrate x/auth encode, decode, broadcast, sign, multisign, and validate-signatures Cmd's to use the TxGenerator Encoder/Decoder methods
add EncodingConfig struct and MakeEncodingConfig methods to simapp and simapp/params to incrementally move towards Full amino encoding support #6190.
remove std.Codec (which is no longer needed because of Any) and replace with codec.Marshaler

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

…l methods

codecov · 2020-06-10T18:35:09Z

Codecov Report

Merging #6391 into master will increase coverage by 0.12%.
The diff coverage is 38.04%.

@@            Coverage Diff             @@
##           master    #6391      +/-   ##
==========================================
+ Coverage   56.13%   56.26%   +0.12%     
==========================================
  Files         467      469       +2     
  Lines       28061    28091      +30     
==========================================
+ Hits        15753    15806      +53     
+ Misses      11201    11170      -31     
- Partials     1107     1115       +8

…ronc/6213-cli-encode

* fixed lint issue of "txEncodeRespStr" * added tests for encode.go * WIP: added tests for decode.go * added txEncoder at bytes * updated decode test * updated txBytes to use TxEncoder in decoder test * added a require after TxEncoder * removed file save * debug decode command * fixed decode tests * added decode cli * updated encode and decode in a single file * separated decode test from encode test * review changes * removed register interface * review change

…ronc/6213-cli-encode

x/auth/client/cli/broadcast_test.go

x/auth/client/cli/cli_test.go

simapp/cmd/simcli/main.go

x/auth/client/cli/validate_sigs.go

x/auth/client/cli/tx_multisign.go

x/auth/client/cli/encode_test.go

…ronc/6213-cli-encode

aaronc · 2020-06-18T16:28:20Z

@fedekunze @anilcse can we please postpone tests for sign, multisign and validate-signatures to other PRs? I am planning to migrate all of those cmd's to protobuf in my next PRs, but I can't do that because I'm blocked by this PR. We have added tests for stuff that makes sense for this PR.

@fedekunze can you take another look and see if it's alright to move forward with this PR with the understanding that this is part of a larger migration of those other commands.

aaronc · 2020-06-18T16:45:33Z

Still fixing one test btw...

aaronc · 2020-06-18T16:59:19Z

@fedekunze fixed tests and added client.TestAccountRetriever in order to get TestPrepareTxBuilder working.

x/auth/client/cli/encode.go

anilcse

LGTM

…onc/6213-cli-encode

fedekunze · 2020-06-18T17:24:00Z

@aaronc looks like a test is failing

alessio

Nice one! ACK'd - pending tests pass

… into aaronc/6213-cli-encode

* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods * Fix tests, add EncodingConfig * Add simapp/encoding.go and wire up with simcli * add godocs * fix tests * Debugging CLI Tests * Fix integration test * 6391 - lint issues and code coverage (cosmos#6414) * fixed lint issue of "txEncodeRespStr" * added tests for encode.go * WIP: added tests for decode.go * added txEncoder at bytes * updated decode test * updated txBytes to use TxEncoder in decoder test * added a require after TxEncoder * removed file save * debug decode command * fixed decode tests * added decode cli * updated encode and decode in a single file * separated decode test from encode test * review changes * removed register interface * review change * Fix tests * WIP add test for tx sign * removed commented code * Fix flags * WIP add test for sign * Address review suggestions * fixed command issue * Add tests for TxEncoder * Revert sign changes * Fix TxEncoder tests * Fix GetSign Cmd * Add tx test * Remove duplicate validation * Add tests for TxDecoder * Fix tests * Fix tests * Output to clientCtx.Output * Fix cli_tests Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: atheesh <atheesh@vitwit.com> Co-authored-by: anilCSE <anil@vitwit.com> Co-authored-by: sahith-narahari <sahithnarahari@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Migrate encode, decode, and broadcast cmd's to use TxGenerator marsha…

92c9a77

…l methods

aaronc added 3 commits June 10, 2020 15:10

Fix tests, add EncodingConfig

fed32e2

Add simapp/encoding.go and wire up with simcli

826785e

add godocs

91cf429

aaronc changed the title ~~Migrate encode, decode, and broadcast cmd's to use TxGenerator marsha…~~ Migrate encode, decode, and broadcast cmd's to TxGenerator methods Jun 10, 2020

aaronc changed the title ~~Migrate encode, decode, and broadcast cmd's to TxGenerator methods~~ Migrate x/auth cmd's to TxGenerator marshaling Jun 10, 2020

aaronc and others added 3 commits June 10, 2020 15:41

Merge branch 'master' into aaronc/6213-cli-encode

eebd0f8

fix tests

1e265f8

Debugging CLI Tests

1467cd4

clevinson added this to the v0.39 milestone Jun 11, 2020

aaronc added 2 commits June 11, 2020 17:04

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…

de78d03

…ronc/6213-cli-encode

Fix integration test

23cdeeb

atheeshp mentioned this pull request Jun 12, 2020

6391 - lint issues and code coverage #6414

Merged

8 tasks

atheeshp and others added 3 commits June 15, 2020 15:28

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…

7b1fc09

…ronc/6213-cli-encode

Fix tests

e4db342

aaronc marked this pull request as ready for review June 15, 2020 19:37

aaronc requested review from alessio, alexanderbez, clevinson, fedekunze and jgimeno as code owners June 15, 2020 19:37

aaronc added R4R C:x/auth labels Jun 15, 2020

anilcse reviewed Jun 15, 2020

View reviewed changes

x/auth/client/cli/broadcast_test.go Show resolved Hide resolved

x/auth/client/cli/cli_test.go Outdated Show resolved Hide resolved

x/auth/client/cli/cli_test.go Outdated Show resolved Hide resolved

anilcse reviewed Jun 15, 2020

View reviewed changes

simapp/cmd/simcli/main.go Show resolved Hide resolved

x/auth/client/cli/validate_sigs.go Show resolved Hide resolved

x/auth/client/cli/tx_multisign.go Show resolved Hide resolved

x/auth/client/cli/encode_test.go Outdated Show resolved Hide resolved

sahith-narahari and others added 4 commits June 18, 2020 20:58

Remove duplicate validation

766f808

Add tests for TxDecoder

e0cb1d4

Merge branch 'master' of https://github.com/cosmos/cosmos-sdk into aa…

2621815

…ronc/6213-cli-encode

Fix tests

78daa5e

fedekunze approved these changes Jun 18, 2020

View reviewed changes

aaronc and others added 2 commits June 18, 2020 12:58

Fix tests

c1d5bf3

Merge branch 'master' into aaronc/6213-cli-encode

3bbd081

aaronc requested a review from anilcse June 18, 2020 16:59

aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 18, 2020

alessio reviewed Jun 18, 2020

View reviewed changes

x/auth/client/cli/encode.go Outdated Show resolved Hide resolved

anilcse approved these changes Jun 18, 2020

View reviewed changes

mergify bot and others added 3 commits June 18, 2020 17:10

Merge branch 'master' into aaronc/6213-cli-encode

4c5ae0d

Output to clientCtx.Output

6cf5831

Merge remote-tracking branch 'origin/aaronc/6213-cli-encode' into aar…

81dc00b

…onc/6213-cli-encode

aaronc removed the A:automerge Automatically merge PR once all prerequisites pass. label Jun 18, 2020

Merge branch 'master' into aaronc/6213-cli-encode

9fd638a

aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 18, 2020

alessio approved these changes Jun 18, 2020

View reviewed changes

mergify bot and others added 3 commits June 18, 2020 18:13

Merge branch 'master' into aaronc/6213-cli-encode

23642fb

Fix cli_tests

2f5ac90

Merge branch 'aaronc/6213-cli-encode' of github.com:cosmos/cosmos-sdk…

f578b59

… into aaronc/6213-cli-encode

mergify bot merged commit 712d237 into master Jun 18, 2020

mergify bot deleted the aaronc/6213-cli-encode branch June 18, 2020 20:29

aaronc mentioned this pull request Jul 7, 2020

Proto Any Tx migration #6213

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate x/auth cmd's to TxGenerator marshaling #6391

Migrate x/auth cmd's to TxGenerator marshaling #6391

aaronc commented Jun 10, 2020 •

edited

Loading

codecov bot commented Jun 10, 2020 •

edited

Loading

aaronc commented Jun 18, 2020

aaronc commented Jun 18, 2020

aaronc commented Jun 18, 2020

anilcse left a comment

fedekunze commented Jun 18, 2020

alessio left a comment

Migrate x/auth cmd's to TxGenerator marshaling #6391

Migrate x/auth cmd's to TxGenerator marshaling #6391

Conversation

aaronc commented Jun 10, 2020 • edited Loading

Summary

Details

codecov bot commented Jun 10, 2020 • edited Loading

Codecov Report

aaronc commented Jun 18, 2020

aaronc commented Jun 18, 2020

aaronc commented Jun 18, 2020

anilcse left a comment

Choose a reason for hiding this comment

fedekunze commented Jun 18, 2020

alessio left a comment

Choose a reason for hiding this comment

aaronc commented Jun 10, 2020 •

edited

Loading

codecov bot commented Jun 10, 2020 •

edited

Loading